This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Refactor ahead of bulk npm #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
Ping @rohitpaulk. Ready for review! :-) |
rohitpaulk
reviewed
Jun 1, 2017
gratipay/email.py
Outdated
| """Load messages queued for sending, and send them. | ||
| """ | ||
| flush_one = _flush_one or self._flush_one |
There was a problem hiding this comment.
Hmm, why is this needed? We've got a console mailer hooked up in the test env, no?
There was a problem hiding this comment.
If the aim is to empty the email queue in tests, might be cleaner to use a separate email_queue.purge() function. (Tests shouldn't have to be aware of the fact that we purge one email at a time)
There was a problem hiding this comment.
Better in c74a413?
|
Looks good to me, aside from this one comment |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prereqs for #4488.
Todo