Integrate initial package claiming PRs #4305

chadwhitacre · 2017-01-24T21:34:04Z

This is an integration branch/PR for the initial implementation of package claiming. Part of #4427.

Specs

See #4297 (comment).

Mocks

From #4297 (comment) (click for full-size):

PRs (in merge order)

Numbers are workflow steps.

(1), (2) add sign in w/ copy to /on/npm/foo/ for anon: Add signin + copy to anon package view #4306 Add link to package on npm #4307 Add a test for anon hitting unclaimed package #4308 Fix regression in test #4323
stub out Package to hold Python API: Stub out Package model #4155
(3)—(6) add confirmation form to /on/npm/foo/ for auth when unclaimed: UI to send confirmation email for unclaimed packages #4309
(7), (8) implement Package.send_confirmation_email: Send confirmation email #4335
(9) add /on/npm/react/claim endpoint to receive email link: Receive package claim link-back #4397
(10)—(11) implement /on/npm/foo/ as project page when claimed: Present claimed packages as projects #4398
(12)—(16) implement /on/npm/foo/edit as project edit page when claimed: Edit claimed packages #4404

&c.

minor refactor: Factor out a package.team mixin #4422
some UX cleanups: Some UX cleanups for package claiming #4406
style the claim form: Style the claim form #4410
more UX cleanups: Clean up UX some more #4411
verify that we can give to a package—the 💟 of the matter! ... Integration test: claim, approve, and give #4423
on verify.html, show packages newly linked if germane: List packages on verification #4424
work PayPal into the workflow somehow: Account for PayPal in claiming workflow #4428
fix an egregious bug at low widths: Fix width bug #4435

Todo

think through merging/takeover—anything special here? like, start verification workflow, then merge accounts, then finish verification.—looks like we already do something … 9b7d147
what about linking an existing project to an existing npm package? … sounds like an admin thing; bump for now, handle through email support
make sure finishing a verification terminates competing verifications (otherwise get_emails can include an email it shouldn't)
think through PayPal requirement—are we accounting for that somewhere here that I'm not seeing?
~~consider notifying other package maintainers when someone claims a package~~ … bumped: Notify other maintainers on package claim #4425
~~indicate to a participant when they have a claim open~~ … bumped: Show open claims to participant #4426
~~check it on a phone~~ … bumped: Fix on a phone #4432
account for deleted packages: Harmonize package deletion and claiming #4448

Landing

change base back to master
merge and deploy!

nobodxbodon · 2017-01-24T22:31:43Z

Could you share the plan of this project?

Besides, I guess you haven't started paying for gomockingbird? Shall we apply to balsamiq earlier than later?

chadwhitacre · 2017-01-24T22:44:48Z

Could you share the plan of this project?

Not sure what you mean. I updated the todo in the ticket description. Not enough?

Besides, I guess you haven't started paying for gomockingbird?

Nope.

Shall we apply to balsamiq earlier than later?

Not a priority for me. a) Balsamiq appears to be desktop-only, which is of limited utility for us since we can't share links, b) I think we have what we need from Mockingbird for now, and c) I think we can hack Mockingbird by deleting cookies/localstorage.

nobodxbodon · 2017-01-24T22:53:52Z

Not sure what you mean. I updated the todo in the ticket description. Not enough?

Maybe just me, but I don't find a easy way to tell which part a dev (me perhaps) can pick up without worrying about stepping on your toe.

a) Balsamiq appears to be desktop-only, which is of limited utility for us since we can't share links,

they offer choices in application including web version:

c) I think we can hack Mockingbird by deleting cookies/localstorage.

Seriously?

chadwhitacre · 2017-01-25T13:36:33Z

Maybe just me, but I don't find a easy way to tell which part a dev (me perhaps) can pick up without worrying about stepping on your toe.

I think we should get you unblocked and focusing on gratipay/finances#35. I'm happy to do the bulk of the work here but I will need you @mattbk @JessaWitzel etc. for review. Let's work with who we have.

they offer choices in application including web version:

Go for it!

Seriously?

😊

chadwhitacre · 2017-01-25T13:37:41Z

@nobodxbodon at #4297 (comment):

When there are multiple contact emails for one package, indicating there are more than one devs, do we send notification emails out to all of them in case the package is claimed by one of the email?

Good idea!

chadwhitacre · 2017-01-25T13:39:07Z

We'll also need to account for the case where an email is attached to a different Gratipay account. They won't be able to use it in that case.

chadwhitacre · 2017-01-25T14:09:12Z

Todo reordered to reflect merge order.

chadwhitacre · 2017-01-26T17:14:58Z

Picking up from #4297 (comment):

I was wondering the same thing. Which email/person do we allow to claim the package.

We pull email addresses from the maintainers and authors in package.json on npm.

nobodxbodon · 2017-01-26T20:13:30Z

In case you missed #4297 (comment), shall we notify all the contacts after step 8 of spec, and states so to the claimer in the email something like "we'll notify all the other coauthors of the package in this email list after you confirm claiming"?

kaguillera · 2017-01-26T21:57:53Z

Is any one of the Co-authors of a package allowed to claim the packages?
What if the co-author is a new-comer claims the package before the real starter of the package gets a chance to.

That was really what I was trying to ask earlier (#4297 (comment))

chadwhitacre · 2017-02-03T19:03:24Z

What's up with the failures here? I seem to recall expecting this ...

chadwhitacre · 2017-02-03T21:31:46Z

Still looking for the perfect process here. I keep switching the todo order. Currently working stepwise through the workflow.

I've got the confirmation flow (3-8) half roughed-in. I think at this point I'm going to go back over and clean up and merge #4155 so that we have a Package object from which to hang API, and then pick up again with #4309. At some point we also could/should rebase this on master to pick up recent changes there.

chadwhitacre · 2017-02-08T19:08:49Z

Is any one of the Co-authors of a package allowed to claim the packages?

No (under):

The thing that seems the most canonical representation from what I've seen around probably is whatever the owners are of the actual npm package vs. what's in the package.json.

Sent a follow-up in private email to clarify:

Looking at the registry, I see three options:

_npmUser—scoped to version

maintainers—scoped to package

author—scoped to package

My hunch based on our convo is that the _npmUser for the latest version is the best one to use for linking (though the _ suggests that this is a private API, and a spot check shows it is missing for some versions, maybe very old ones?). Does that sound right to you?

chadwhitacre · 2017-02-08T19:20:27Z

Alright, based on that and considerations at #4309 (comment) I've added another prereq:

update schema for a single (nullable) email & sync from the latest version's _npmUser

chadwhitacre · 2017-02-08T19:33:01Z

Okay! Shelving work on #4309. I had thought of two PRs right after that one (implementing .send_confirmation_email), and then confirmation link post-back). But now it seems I should dial back to working on npm syncing prereqs.

chadwhitacre · 2017-02-08T20:55:45Z

Scratch that! 💃

Taking a look at a few packages, it is definitely the maintainers field that I had in mind, as the corresponds to the users who have the rights to publish the package, which is the most likely to align to the folks who would manage any funds, imo

Aligns with doco:

Add a new user as a maintainer of a package. This user is enabled to modify metadata, publish new versions, and add other owners.

Note that there is only one level of access. Either you can modify a package, or you can't. Future versions may contain more fine-grained access levels, but that is not implemented at this time.

https://docs.npmjs.com/cli/owner

npm also sets a top-level "maintainers" field with your npm user info.

https://docs.npmjs.com/files/package.json#people-fields-author-contributors

chadwhitacre · 2017-02-08T20:59:53Z

But we do want to drop author.

chadwhitacre · 2017-02-08T21:02:11Z

/me adds that to prereqs ...

chadwhitacre · 2017-02-08T21:02:27Z

Back into #4309!

chadwhitacre · 2017-02-20T15:36:42Z

Squashed and rebased onto #4343, was 5bab99a.

chadwhitacre · 2017-05-02T12:50:08Z

Awesome. All PRs are in!

I guess we should spend some effort on syncing npm before we deploy this, though. :-/

chadwhitacre · 2017-05-02T12:50:48Z

The snapshot of npm we have in the Gratipay database is six months old. We need to update that and also build in a mechanism for constantly updating it.

chadwhitacre · 2017-05-05T18:16:31Z

Rebased and squashed, was 70b391e.

chadwhitacre · 2017-05-09T15:05:25Z

Okay, friends! I believe we are ready to land this sucker!

chadwhitacre · 2017-05-09T20:52:59Z

@clone1018 and I are going to merge and deploy this.

Includes: #4304 #4306 #4307 #4308 #4309 #4155 #4323

Includes: #4335 #4397 #4398 #4404 #4422 #4406 #4410 #4411 #4423

Includes: #4424 #4428 4435

- Move upsert & delete onto Package - Make verification results easier to debug - Smooth out a slight very wrinkle in return value for paypal_updated - Implement and test desired behavior

chadwhitacre · 2017-05-09T20:57:36Z

Rebased, was 8a2e258.

chadwhitacre · 2017-05-09T21:19:48Z

Travis is running super-slow.

chadwhitacre · 2017-05-09T22:01:01Z

Finally green! Ready!?

From #4305

chadwhitacre mentioned this pull request Jan 24, 2017

Spec out claim/unclaim/reclaim packages #4297

Closed

5 tasks

chadwhitacre added the ✈️ Flight Deck ✈️ label Jan 24, 2017

chadwhitacre force-pushed the project/claim-packages branch from 37cc930 to d06e5f2 Compare January 24, 2017 22:39

chadwhitacre mentioned this pull request Jan 24, 2017

Add signin + copy to anon package view #4306

Merged

chadwhitacre mentioned this pull request Jan 25, 2017

UI to send confirmation email for unclaimed packages #4309

Merged

chadwhitacre changed the title ~~Implement claim/unclaim/reclaim packages~~ ✈️ Implement claim/unclaim/reclaim packages Feb 8, 2017

This was referenced Feb 9, 2017

— #4326

Closed

Send confirmation email #4335

Merged

chadwhitacre mentioned this pull request Feb 20, 2017

Refactor mixins #4343

Merged

chadwhitacre force-pushed the project/claim-packages branch from 5bab99a to bdd20ac Compare February 20, 2017 15:42

chadwhitacre mentioned this pull request Apr 28, 2017

Fix width bug #4435

Merged

chadwhitacre mentioned this pull request May 3, 2017

Rebuild npm syncing #4438

Merged

8 tasks

chadwhitacre added the Blocked label May 4, 2017

chadwhitacre force-pushed the project/claim-packages branch from 70b391e to 49c9359 Compare May 5, 2017 18:16

chadwhitacre mentioned this pull request May 5, 2017

Harmonize package deletion and claiming #4448

Merged

chadwhitacre removed the Blocked label May 5, 2017

chadwhitacre added 4 commits May 9, 2017 15:57

Checkpoint 1

18ab883

Includes: #4304 #4306 #4307 #4308 #4309 #4155 #4323

Checkpoint 2

24559cb

Includes: #4335 #4397 #4398 #4404 #4422 #4406 #4410 #4411 #4423

Checkpoint 3

dc542cb

Includes: #4424 #4428 4435

Harmonize package deletion and claiming

a2abfdb

- Move upsert & delete onto Package - Make verification results easier to debug - Smooth out a slight very wrinkle in return value for paypal_updated - Implement and test desired behavior

chadwhitacre force-pushed the project/claim-packages branch from 8a2e258 to a2abfdb Compare May 9, 2017 20:57

clone1018 merged commit f21477c into master May 9, 2017

chadwhitacre deleted the project/claim-packages branch May 9, 2017 22:02

chadwhitacre mentioned this pull request May 9, 2017

Add a check in deploy.sh for environment variables #4446

Closed

chadwhitacre added a commit that referenced this pull request May 10, 2017

Fix search css regression

c07ea82

From #4305

This was referenced May 10, 2017

Fix search css regression #4456

Merged

Go to OSCON 2017 gratipay/inside.gratipay.com#948

Closed

Get deployment back on track w/ npm in search #4459

Closed

rohitpaulk mentioned this pull request May 11, 2017

Investigate spike in response time #4460

Closed

chadwhitacre mentioned this pull request May 17, 2017

Move projects under participants in URL structure #4246

Closed

chadwhitacre mentioned this pull request May 25, 2017

IntegrityError participants_email_address_key #4487

Closed

chadwhitacre mentioned this pull request Jul 17, 2017

Add email auth #4539

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate initial package claiming PRs #4305

Integrate initial package claiming PRs #4305

chadwhitacre commented Jan 24, 2017 •

edited

Loading

nobodxbodon commented Jan 24, 2017

chadwhitacre commented Jan 24, 2017

nobodxbodon commented Jan 24, 2017

chadwhitacre commented Jan 25, 2017

chadwhitacre commented Jan 25, 2017

chadwhitacre commented Jan 25, 2017

chadwhitacre commented Jan 25, 2017

chadwhitacre commented Jan 26, 2017

nobodxbodon commented Jan 26, 2017

kaguillera commented Jan 26, 2017 •

edited

Loading

chadwhitacre commented Feb 3, 2017

chadwhitacre commented Feb 3, 2017

chadwhitacre commented Feb 8, 2017

chadwhitacre commented Feb 8, 2017

chadwhitacre commented Feb 8, 2017

chadwhitacre commented Feb 8, 2017 •

edited

Loading

chadwhitacre commented Feb 8, 2017 •

edited

Loading

chadwhitacre commented Feb 8, 2017

chadwhitacre commented Feb 8, 2017

chadwhitacre commented Feb 20, 2017

chadwhitacre commented May 2, 2017

chadwhitacre commented May 2, 2017

chadwhitacre commented May 5, 2017

chadwhitacre commented May 9, 2017

chadwhitacre commented May 9, 2017

chadwhitacre commented May 9, 2017

chadwhitacre commented May 9, 2017

chadwhitacre commented May 9, 2017

Integrate initial package claiming PRs #4305

Integrate initial package claiming PRs #4305

Conversation

chadwhitacre commented Jan 24, 2017 • edited Loading

Specs

Mocks

PRs (in merge order)

&c.

Todo

Landing

nobodxbodon commented Jan 24, 2017

chadwhitacre commented Jan 24, 2017

nobodxbodon commented Jan 24, 2017

chadwhitacre commented Jan 25, 2017

chadwhitacre commented Jan 25, 2017

chadwhitacre commented Jan 25, 2017

chadwhitacre commented Jan 25, 2017

chadwhitacre commented Jan 26, 2017

nobodxbodon commented Jan 26, 2017

kaguillera commented Jan 26, 2017 • edited Loading

chadwhitacre commented Feb 3, 2017

chadwhitacre commented Feb 3, 2017

chadwhitacre commented Feb 8, 2017

chadwhitacre commented Feb 8, 2017

chadwhitacre commented Feb 8, 2017

chadwhitacre commented Feb 8, 2017 • edited Loading

chadwhitacre commented Feb 8, 2017 • edited Loading

chadwhitacre commented Feb 8, 2017

chadwhitacre commented Feb 8, 2017

chadwhitacre commented Feb 20, 2017

chadwhitacre commented May 2, 2017

chadwhitacre commented May 2, 2017

chadwhitacre commented May 5, 2017

chadwhitacre commented May 9, 2017

chadwhitacre commented May 9, 2017

chadwhitacre commented May 9, 2017

chadwhitacre commented May 9, 2017

chadwhitacre commented May 9, 2017

chadwhitacre commented Jan 24, 2017 •

edited

Loading

kaguillera commented Jan 26, 2017 •

edited

Loading

chadwhitacre commented Feb 8, 2017 •

edited

Loading

chadwhitacre commented Feb 8, 2017 •

edited

Loading