Show as closed #4292
Show as closed #4292
Conversation
- fix bugs in balance checking (`> 0` vs `!= 0`) - allow admins to close accounts w/ balance - refactor test suite a little bit - add tests
Still a bit confobulated due to surrounding markup in various contexts.
For owners and admins, to avoid confusion.
|
Another one, @mattbk et al. |
| assert P('alice').is_closed | ||
|
|
||
| def test_close_can_be_overriden_for_negative_balance_too(self): | ||
| alice = self.make_participant('alice', claimed_time='now', balance=D('10.00')) |
There was a problem hiding this comment.
Good catch! Fixed in 0d2deb6.
| assert response.code == 400 | ||
| assert not P('alice').is_closed | ||
|
|
||
| def test_posting_with_balance_succeeds_for_admin(self): |
There was a problem hiding this comment.
append "_with_negative_balance" in method name?
There was a problem hiding this comment.
Meh. We have tests above for the full matrix of {positive,negative} * {owner,admin}. The point here is to test with any balance. The fact that this one is negative while the previous test uses a positive balance is just extra.
There was a problem hiding this comment.
Because here we're running through the simplate, where the positive/negative isn't so much an issue as the permissions for various roles.
There was a problem hiding this comment.
There's a principle in testing that making test case mimimal/simplest to achieve the test goal. Any additional conditions would add noise and unnecessery maintanance burden (consider other contributors having the same confusion as me).
Of course that's in theory :)
|
I'm good to go here if you're good with 0d2deb6, @nobodxbodon. 👍 |
|
Oh, I see. It just hangs out in the database, but the account is closed. I guess we're assuming that this isn't likely to be a problem, because people will either want their money before closing or it will be small amounts. It should be easy enough to look up how much "abandoned" money there is in closed accounts in the future. I'm satisfied with this. Pushing the button. |
|
@mattbk Participants can't close their account with a balance outstanding, but #4291 allows admins to do so, which is necessary for #3602 (comment). |
Following on from #4291 (which is included here), this adds a danger zone to the top of the project page, which is still accessible to owners and admins.