Implement project (Team) closing #4287

chadwhitacre · 2017-01-11T16:22:45Z

See #3602.

chadwhitacre · 2017-01-11T16:58:52Z

Interesting. We already have an is_closed field. :-)

chadwhitacre · 2017-01-11T17:04:25Z

We even use it (etc.)!

chadwhitacre · 2017-01-11T18:40:20Z

I don't understand how the edit form is wired.

chadwhitacre · 2017-01-11T18:52:17Z

We're using global vars and FormData,

chadwhitacre · 2017-01-11T18:53:55Z

We're probably using FormData to account for the file upload.

chadwhitacre · 2017-01-11T19:44:03Z

Ready for review, @mattbk @nobodxbodon et al.

mattbk · 2017-01-11T20:46:12Z

Closing my own or another project as admin:

Traceback (most recent call last):
  File "/home/matt/Documents/gratipay/gratipay.com/env/lib/python2.7/site-packages/algorithm.py", line 288, in run
    new_state = function(**deps.as_kwargs)
  File "/home/matt/Documents/gratipay/gratipay.com/env/lib/python2.7/site-packages/aspen/algorithms/website.py", line 115, in get_response_for_resource
    return {'response': resource.respond(state)}
  File "/home/matt/Documents/gratipay/gratipay.com/env/lib/python2.7/site-packages/aspen/http/resource.py", line 59, in respond
    content_type, body = super(Dynamic, self).respond(accept, state)
  File "/home/matt/Documents/gratipay/gratipay.com/env/lib/python2.7/site-packages/aspen/simplates/__init__.py", line 169, in respond
    exec(self.pages[1], context)
  File "/home/matt/Documents/gratipay/gratipay.com/www/~/%username/index.html.spt", line 16, in <module>
    statement, stmt_lang = participant.get_statement(request.accept_langs)
  File "/home/matt/Documents/gratipay/gratipay.com/gratipay/models/participant/__init__.py", line 204, in get_statement
    """, dict(id=self.id, langs=langs), default=(None, None, None))
  File "/home/matt/Documents/gratipay/gratipay.com/env/lib/python2.7/site-packages/postgres/__init__.py", line 482, in one
    return cursor.one(sql, parameters, default)
  File "/home/matt/Documents/gratipay/gratipay.com/env/lib/python2.7/site-packages/postgres/cursors.py", line 105, in one
    out = self._some(sql, parameters, lo=0, hi=1)
  File "/home/matt/Documents/gratipay/gratipay.com/env/lib/python2.7/site-packages/postgres/cursors.py", line 127, in _some
    self.execute(sql, parameters)
  File "/home/matt/Documents/gratipay/gratipay.com/env/lib/python2.7/site-packages/psycopg2/extras.py", line 288, in execute
    return super(NamedTupleCursor, self).execute(query, vars)
ProgrammingError: column "content_scrubbed" does not exist
LINE 2:             SELECT content, content_scrubbed, lang

mattbk · 2017-01-11T20:48:15Z

Will make clean env and try again.

mattbk · 2017-01-11T20:52:12Z

But if I refresh, it says "already closed."

chadwhitacre · 2017-01-11T21:08:42Z

column "content_scrubbed" does not exist

That suggests that you needed to make schema to pick up the new column from #4266.

chadwhitacre · 2017-01-11T21:09:39Z

But if I refresh, it says "already closed."

Okay, so the close succeeded and the content_scrubbed error came afterwards?

mattbk · 2017-01-11T21:26:46Z

Okay, so the close succeeded and the content_scrubbed error came afterwards?

Clicking "close" gave me the error, but the close succeeded. Getting back up to speed.

mattbk · 2017-01-11T21:30:55Z

Looks good from here!

mattbk · 2017-01-11T21:34:23Z

Closed project is still listed on and accessible from ~user's profile.

nobodxbodon · 2017-01-11T21:32:23Z

www/%team/edit/close.spt

+    raise Response(403, _("You are not authorized to access this page."))
+
+if team.is_closed:
+    raise Response(403, _("Already closed."))


How about disable "close" button instead?

I think this was quicker to put together. We can enhance (add project reopening?) once the basic functionality is there.

Sounds good. BTW after your latest commit (hide closed team), in theory user should not reach here, as they won't see the already closed teams?

If you try to close again by URL for some reason, you would get this error. All my latest commit did was hide the link to the project from the project owner's profile.

mattbk · 2017-01-12T00:27:51Z

I hope to check through this again tonight and try to fix anything I find.

mattbk · 2017-01-12T03:44:18Z

Closed project is still listed on and accessible from ~user's profile.

Fixxored in 6b191f0

I like it!

Better match what we've already got.

chadwhitacre · 2017-01-12T18:17:53Z

I added 36948c0 to improve (and test) our behavior around listing projects on owner profiles.

How does that look, @mattbk @nobodxbodon? Are we ready to merge?

mattbk · 2017-01-12T18:37:43Z

Good to me.

chadwhitacre · 2017-01-12T19:06:32Z

You good, @nobodxbodon?

nobodxbodon · 2017-01-12T19:38:18Z

@whit537 sorry I'm not sure I can review your latest commit 36948c0 today. Please go ahread and merge if LG to both of you?

BTW I feel the trickiness when a PR involves multiple peoples' commits. Ideally a third person who doesn't have commits should merge?

mattbk · 2017-01-12T19:46:27Z

If it makes you feel better, @whit537's commit overwrote mine 😉.

chadwhitacre · 2017-01-12T19:51:46Z

It improved on yours. :-P

@mattbk The merge is yours, I think.

chadwhitacre · 2017-01-12T19:56:07Z

So is the delete branch? 👁️

mattbk · 2017-01-12T19:58:26Z

😝

Failing test for team (project) closing

e33a69e

chadwhitacre mentioned this pull request Jan 11, 2017

Add project closing #3602

Closed

5 tasks

chadwhitacre added this to the Finish Project Basics milestone Jan 11, 2017

chadwhitacre added 2 commits January 11, 2017 12:17

Add Python API for closing teams

08627ab

Harmonize "Close" styles across pages

20ec01e

chadwhitacre added 4 commits January 11, 2017 14:43

Add UI for closing a project

d453ecd

Don't show closed teams on the homepage

c7fa2b1

Trim whitespace

de2aa54

Add projects notice to participant close page

03b264f

chadwhitacre force-pushed the project-closing branch from c5413d2 to 03b264f Compare January 11, 2017 19:43

chadwhitacre added the Review label Jan 11, 2017

chadwhitacre mentioned this pull request Jan 11, 2017

What sequence of steps do I need to perform to eradicate my account? #4286

Closed

Bring participant close tests up to date

73926df

nobodxbodon reviewed Jan 11, 2017

View reviewed changes

Hide closed teams from ~user profile

6b191f0

Beef up implementation of closed filtering

36948c0

Better match what we've already got.

chadwhitacre force-pushed the project-closing branch from f2afb0e to 36948c0 Compare January 12, 2017 18:17

mattbk merged commit e10a405 into master Jan 12, 2017

mattbk deleted the project-closing branch January 12, 2017 19:58

chadwhitacre mentioned this pull request Jan 12, 2017

Fix bug with closing account w/ closed project #4289

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement project (Team) closing #4287

Implement project (Team) closing #4287

chadwhitacre commented Jan 11, 2017 •

edited

Loading

chadwhitacre commented Jan 11, 2017

chadwhitacre commented Jan 11, 2017

chadwhitacre commented Jan 11, 2017

chadwhitacre commented Jan 11, 2017

chadwhitacre commented Jan 11, 2017

chadwhitacre commented Jan 11, 2017

mattbk commented Jan 11, 2017 •

edited

Loading

mattbk commented Jan 11, 2017

mattbk commented Jan 11, 2017

chadwhitacre commented Jan 11, 2017

chadwhitacre commented Jan 11, 2017

mattbk commented Jan 11, 2017

mattbk commented Jan 11, 2017

mattbk commented Jan 11, 2017

nobodxbodon Jan 11, 2017

mattbk Jan 12, 2017

nobodxbodon Jan 12, 2017

mattbk Jan 12, 2017

mattbk commented Jan 12, 2017

mattbk commented Jan 12, 2017 •

edited

Loading

chadwhitacre commented Jan 12, 2017

mattbk commented Jan 12, 2017

chadwhitacre commented Jan 12, 2017

nobodxbodon commented Jan 12, 2017

mattbk commented Jan 12, 2017

chadwhitacre commented Jan 12, 2017 •

edited

Loading

chadwhitacre commented Jan 12, 2017

mattbk commented Jan 12, 2017

Implement project (Team) closing #4287

Implement project (Team) closing #4287

Conversation

chadwhitacre commented Jan 11, 2017 • edited Loading

chadwhitacre commented Jan 11, 2017

chadwhitacre commented Jan 11, 2017

chadwhitacre commented Jan 11, 2017

chadwhitacre commented Jan 11, 2017

chadwhitacre commented Jan 11, 2017

chadwhitacre commented Jan 11, 2017

mattbk commented Jan 11, 2017 • edited Loading

mattbk commented Jan 11, 2017

mattbk commented Jan 11, 2017

chadwhitacre commented Jan 11, 2017

chadwhitacre commented Jan 11, 2017

mattbk commented Jan 11, 2017

mattbk commented Jan 11, 2017

mattbk commented Jan 11, 2017

nobodxbodon Jan 11, 2017

Choose a reason for hiding this comment

mattbk Jan 12, 2017

Choose a reason for hiding this comment

nobodxbodon Jan 12, 2017

Choose a reason for hiding this comment

mattbk Jan 12, 2017

Choose a reason for hiding this comment

mattbk commented Jan 12, 2017

mattbk commented Jan 12, 2017 • edited Loading

chadwhitacre commented Jan 12, 2017

mattbk commented Jan 12, 2017

chadwhitacre commented Jan 12, 2017

nobodxbodon commented Jan 12, 2017

mattbk commented Jan 12, 2017

chadwhitacre commented Jan 12, 2017 • edited Loading

chadwhitacre commented Jan 12, 2017

mattbk commented Jan 12, 2017

chadwhitacre commented Jan 11, 2017 •

edited

Loading

mattbk commented Jan 11, 2017 •

edited

Loading

mattbk commented Jan 12, 2017 •

edited

Loading

chadwhitacre commented Jan 12, 2017 •

edited

Loading