This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Fix CSP #4250
Merged
Fix CSP #4250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, I'll get straight on to that! |
|
@EdOverflow Look into inline scripts, ya? |
|
I fixed the font errors in 961ce59. |
👍 |
|
I am rolling back in Heroku for now ... |
|
Sorry about that. :( |
|
@EdOverflow Don't worry about it, that's the magic of Open Source! |
chadwhitacre
commented
Dec 22, 2016
| @@ -51,6 +51,7 @@ def add_headers_to_response(response): | |||
| 'style-src assets.gratipay.com cloud.typography.com;' | |||
| 'img-src *;' | |||
| 'font-src assets.gratipay.com cloud.typography.com;' | |||
| "script-src 'unsafe-inline'" | |||
There was a problem hiding this comment.
We're missing a semicolon at the end here, ya? Addressed in 75ce62f.
|
@EdOverflow You good with 75ce62f? |
|
OK, now it should work. Thanks @whit537! :) |
|
@EdOverflow May I let you hit the big green "Merge pull request" button here on GitHub? :-) |
|
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't careful enough in #4244 / #4247 and broke the site:
cc: @EdOverflow