Fix Faker again

[chadwhitacre]

First attempt in #4224 didn't work: #4221 (comment).

[chadwhitacre]

It would seem that we're passing in a start date in the future, since end_date defaults to now.

        if step == 1:
>           raise ValueError, "empty range for randrange() (%d,%d, %d)" % (istart, istop, width)
E           ValueError: empty range for randrange() (1481258996,1481141523, -117473)
/opt/python/2.7.12/lib/python2.7/random.py:218: ValueError

https://travis-ci.org/gratipay/gratipay.com/builds/182073772

Reviewing joke2k/faker#282 ...

[chadwhitacre]

[gratipay] $ date -j -r 1481258996
Thu Dec  8 23:49:56 EST 2016
[gratipay] $ date -j -r 1481141523
Wed Dec  7 15:12:03 EST 2016
[gratipay] $

[chadwhitacre]

[gratipay] $ date
Wed Dec  7 16:44:28 EST 2016
[gratipay] $

[chadwhitacre]

It looks like the end date is accurate (did that build really run 90 minutes ago?).

[chadwhitacre]

[chadwhitacre]

Yes: 2016-12-07T20:12:41Z.

[chadwhitacre]

(EST is UTC-5.)

[chadwhitacre]

Alright, so end_date is fine. What's up with start_date?

[chadwhitacre]

The range on joke2k/faker#282 is different: (0,-10325, -10325).

[chadwhitacre]

Alright, so where do participant.claimed_time and team.ctime come from?

[chadwhitacre]

Huh ... participant.claimed_time is calculated as seven days after ctime, which is a random time between three years ago and now. So if ctime ends up within the last week, that would put start_date in the future. Whatever team.ctime is would need to be even further in the future to be preferred—but nonetheless where does that come from?

[chadwhitacre]

As it happens though, team.ctime is also seven days after the owner's ctime. Participant is not the team owner.

[chadwhitacre]

How about 216ad15 545eb59, @mattbk @kaguillera?

[chadwhitacre]

😢

http://faker.readthedocs.io/en/master/communityproviders.html

[mattbk]

This logic makes sense to me.