Make search search teams as well #4222
Conversation
|
Not the greatest. I toyed with copying the table on the front page, but that would involve moving the sidebar as well.
|
|
Per last commit, should look like The project name is not big, and there is no line at the bottom of the row. CSS? |
|
Cleaning the environment. Search of |
|
I'll probably make the project name results display the same as the project description results for consistency and differentiation from ~user results. |
mattbk
requested review from
kaguillera,
JessaWitzel,
chadwhitacre and
clone1018
and removed request for
kaguillera
|
Ready for review. |
|
I would love to review this but when I checkout the branch and run it locally there is no data so I cannot test the search function. What should I do? |
|
Have you run "make fake" as mentioned in the readme? |
|
Added to #4221 since right now we're lying. Also #4157 (comment). |
|
Can we do something about the styling? Don't need to go overboard (the search feature needs an overhaul), but maybe at least reuse the "username" tile styling for projects?
|
|
Also, if we're not going to do excerpts for project descriptions like we do for participant statements, then I think we should just drop project descriptions from both the fields searched and the results display. Even just searching over project names is enough to undo the lie we're currently caught in. :-) |
|
From what I'm seeing this does include an excerpt from the product description? Am I missing something? |
|
Also I like that the styling is different so that you can see the entire project name. Do you mean that you want the same tile look @whit537 ? |
|
If you look at the CSS, you can see that I tried styling them similar to the front page, but it doesn't seem to work. The project list includes the first 100 characters of the description, not a search-style excerpt as it does for ~user profiles. I was trying for a minimum working product. |
|
Well, our search experience is really, really rough right now. I'm looking for how to not make it too much worse while also getting this out the door quickly. I think our best bet is to maintain parallelism in the UI with the user results. I think we should have "FOUND A MATCHING PROJECT NAME" with a little tile like we have under "MATCHING USERNAMES." We should drop the description since for users that's a separate section of the page. I don't think we should bother adding a section for matching project descriptions in the interest of expediency.
|
Not a bad point, but I think we should address that outside of this PR in a search overhaul. |
|
I'm gonna make some commits ... |
|
Project searches both project name and description, and returns both. What if I'm searching for something like "python" because I want to support Python projects? A logo and a project name don't tell me anything about a project. I previously had separate sections for project name and project description, then combined them because for the searcher, it probably doesn't matter. |
|
It's funny, I'm just landing a 3-month project with COS to write a test suite for private search, and over here we have zero tests. :P |
|
I also disagree that projects should be presented in the same way as ~users. That's confusing. Ideally all projects should be presented as on the front page, even on ~user pages that are listing projects. E.g., |
We added this way back in our first pull request, #2. As it suggests there, this was in lieu of a real search feature. I think we should remove it because: - We no longer focus on individuals through their social network accounts - We have a real search feature - This clutters up the search page - It's sugar for going to /on/twitter/foo/ directly; you can still get there
|
Progress on restyling:
|
|
I'm trying to wrestle the text part into the details field. Once I've got that neat I think we'll be back to review here.
|
|
Heck to the yeah! 💃 👍
|
|
Works in Chrome and Safari, borked in Firefox. |
|
I like it. Thanks for digging in. |
|
Got it! |
chadwhitacre
force-pushed
the
search-projects
branch
from
8e48f4b to
c7d0647
Compare
|
I have the text description integrated with the homepage listing style, and it's working for both username search (showing the beginning of the statement) as well as user statement matches (showing the relevant excerpt as before). It works responsively, and doesn't break the homepage (though as a side-effect, the details on the homepage now overflow hiddenly with ellipsis rather than float dropping). I've tested in Chrome, Safari, and Firefox on macOS.
|
|
Back over to you for review, @JessaWitzel @mattbk! |
|
Here it is on some backup data. It's interesting that
|
|
Oops! 😊
|
|
Fixed in 4da2981. |
|
@JessaWitzel in slack:
👍 I'll let you reticket if you like. :-) |
|
I approve.
Probably because |
💃
Yeah, searching for |
|
Woo! !m @JessaWitzel |
|
Deployed! Huzzah! 💃 !m @mattbk @JessaWitzel *
|
Closes #3872.
Stubbing out a barely working version.
product_or_serviceproduct_or_servicethe same way ~user statements are