Wrap marky-markdown #4154
Wrap marky-markdown #4154
Conversation
chadwhitacre
added this to the Refocus on Corporate Sponsorship of Open Source milestone
|
Will calling an external process on each render be performant enough? Why not use something like https://github.com/lepture/mistune? |
|
Aha, github has it's own flavor of markdown and mistune and the likes may not support all those features. |
|
grip is pretty cool but it's no different than what we're trying to do with marky-markdown. |
|
do we have tests for this? |
But we should. :-) |
|
@aandis For now can we add even just one test that runs some very simple markdown through |
|
🍏 |
Does that mean "Ready for review?" :-) |
|
Yep. :) |
| """ | ||
| echo = Popen(("echo", markdown), stdout=PIPE) | ||
| marky = Popen(("marky-markdown", "/dev/stdin"), stdin=echo.stdout, stdout=PIPE) | ||
| return Markup(marky.communicate()[0]) |
There was a problem hiding this comment.
Can't we pass markdown into the communicate call rather than the echo hack?
There was a problem hiding this comment.
Didn't know pipe could work with that. Nice! Done in ecdc8e0
|
Sigh, looks like #4129 didn't work. :-/ |
|
/me restarts build ... |
|
!m @aandis 💃 |
marky-markdown is the markdown parser that npm uses. We should use it with npm package readmes. There's a CLI that we should be able to wrap. It doesn't take
stdinbut we can work around that using/dev/stdinlike so: