Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Add user.participant to who can see giving numbers #3788

Merged
merged 5 commits into from
Sep 20, 2015

Conversation

mattbk
Copy link
Contributor

@mattbk mattbk commented Sep 16, 2015

#3783

Someone else should check this locally because I can't right now.

@chadwhitacre
Copy link
Contributor

723392c will show for any authenticated user. We want something more like user.participant == participant.

@mattbk
Copy link
Contributor Author

mattbk commented Sep 17, 2015

Looks good on local, ready for review.

@chadwhitacre
Copy link
Contributor

Rebased on #3792 to pick up that fix, and then I inserted a couple commits with working tests for [hidden] behavior generally and failing tests for #3783. Original HEAD was bad66f9.

@chadwhitacre
Copy link
Contributor

Hmmm ... unrelated UnicodeDecodeErrors ...

chadwhitacre and others added 3 commits September 19, 2015 20:17
#3783

Someone else should check this locally because I can't right now.
@chadwhitacre
Copy link
Contributor

Alright, should be resolved. Let's see what Travis says ...

chadwhitacre added a commit that referenced this pull request Sep 20, 2015
Add user.participant to who can see giving numbers
@chadwhitacre chadwhitacre merged commit 1883807 into master Sep 20, 2015
@chadwhitacre chadwhitacre deleted the hidden-giving-fix branch September 20, 2015 01:44
@chadwhitacre
Copy link
Contributor

!m @mattbk

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants