This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 308
charge on Braintree #3470
Merged
Merged
charge on Braintree #3470
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b223d4d
Start looking at charging on Braintree
chadwhitacre 2a0ddaa
Basic test for fetch_card_holds
chadwhitacre de66ffe
Fixture to support test in previous commit
chadwhitacre 89d6538
Fix create_card_hold tests to use Braintree
rohitpaulk 54a923e
Group card hold tests by `create` and `capture`
rohitpaulk 358d383
Fix create_card_hold to use Braintree
rohitpaulk d5c3c79
Fix capture_card_hold tests, and void card holds after tests
rohitpaulk a128256
group capture_card_hold tests properly
rohitpaulk 7628138
fix capture_card_hold and cancel_card_hold
rohitpaulk 87c0994
Use braintree cards in payday
rohitpaulk 3a7edd9
Add `braintree_customer_id` to payday_participants
rohitpaulk 07c86db
Handle braintree holds in payday
rohitpaulk db6bd23
fix tests in test_billing_payday.py
rohitpaulk 38eaffa
Changes to fixtures
rohitpaulk a543a8a
Mark sync with balanced tests for debits as xfail
rohitpaulk 06516aa
Update syncWithBalanced fixtures
rohitpaulk 08f782d
Remove unused imports
rohitpaulk 7153853
Perform braintree cleanup on every tearDown
rohitpaulk 68187c5
Update Fixtures after last commit
rohitpaulk 6d36b31
remove unused import
rohitpaulk 98aacf9
Remove set_trace calls ;)
chadwhitacre 71da515
Fix up a couple Balanced references in logs
chadwhitacre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we in danger of float errors here? Why type is
cents
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cents
is anint
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You positive? I thought it was a
Decimal
here. Regardless, if Braintree accepts dollars we should just pass dollars. We only convert to cents in_prep_hit
because Balanced wanted cents (though doesach_credit
also use_prep_hit
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm reading correctly,
cents
comes from_prep_hit
- and https://github.com/gratipay/gratipay.com/blob/master/gratipay/billing/exchanges.py#L288True. I wanted to minimize the code changes here, that's why I reused the function.
No, it doesn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can clean that up later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reticketed as #3500.