Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

turn on subscriptions #3467

Merged
merged 8 commits into from
May 21, 2015
Merged

turn on subscriptions #3467

merged 8 commits into from
May 21, 2015

Conversation

chadwhitacre
Copy link
Contributor

Closes #3432.

@chadwhitacre chadwhitacre added this to the Pivot milestone May 21, 2015
@chadwhitacre
Turn off Members, Receiving, and Giving pages
426d63c 
Too much to convert Giving to Subscriptions as part of #3467, because it
depends on caching, which is a lot of work to change.
@chadwhitacre chadwhitacre force-pushed the turn-on-subscriptions branch from 33d49f0 to 426d63c Compare May 21, 2015 13:42
@chadwhitacre
Copy link
Contributor Author

I'm leaving the work of convert Profile > Giving to Profile > Subscriptions to another PR: #3468.

@chadwhitacre chadwhitacre mentioned this pull request May 21, 2015
Closed
@chadwhitacre
Replace Profile > Giving with > Subscriptions
6514898 
Removes Profile > {Members,Receiving} entirely.

Conflicts:
	templates/profile-subnav.html
@chadwhitacre
Copy link
Contributor Author

Ready for review, @rohitpaulk et al.

@chadwhitacre
Copy link
Contributor Author

Now that #3469 is deployed, this is our only blocker to #3419 (comment).

@rohitpaulk
Copy link
Contributor

I don't have time today for a complete review - I tested this on a backup and from the outside, seems to work fine. One quick problem I see - When I cancel a tip, the notification says -

Payment changed to $0.00 per week. Thank you so much for supporting Gratipay!

@chadwhitacre
Copy link
Contributor Author

@rohitpaulk Okay. I reeeeeeaaaallly want to get #3419 out the door so we can respond to all of these users that are waiting to hear from us. If you're not able to review this tomorrow then we should either a) deploy w/o a full review, or b) revise #3419 to say we're still working on this.

@rohitpaulk
Copy link
Contributor

I say go ahead and deploy :)

@chadwhitacre
Copy link
Contributor Author

Okay! 💃

chadwhitacre added a commit that referenced this pull request May 21, 2015
@chadwhitacre
Merge pull request #3467 from gratipay/turn-on-subscriptions
e0da322 
turn on subscriptions
@chadwhitacre chadwhitacre merged commit e0da322 into master May 21, 2015
@chadwhitacre chadwhitacre deleted the turn-on-subscriptions branch May 21, 2015 22:47
This was referenced May 22, 2015
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Review
Projects
None yet
Milestone
Pivot
Development

Successfully merging this pull request may close these issues.

turn subscriptions back on in UI
2 participants
@chadwhitacre @rohitpaulk