Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Fix payment table semantics #3430

Merged
merged 4 commits into from
May 15, 2015
Merged

Fix payment table semantics #3430

merged 4 commits into from
May 15, 2015

Conversation

rohitpaulk
Copy link
Contributor

@rohitpaulk rohitpaulk changed the title Failing tests for payment amounts Fix payment table semantics May 15, 2015
@rohitpaulk
Copy link
Contributor Author

I'd really like to fix _check_balances before we retry #3415. I don't have the time to fix it now, but I should be able to within 3-4 hours.

EDIT: Never mind, done.

This was referenced May 15, 2015
Merged
Closed
@chadwhitacre
Copy link
Contributor

I'm ready to merge if you're okay with 46f047b, @rohitpaulk.

rohitpaulk added a commit that referenced this pull request May 15, 2015
@rohitpaulk
Merge pull request #3430 from gratipay/fix-payments-table-semantics
8ace23d 
Fix payment table semantics
@rohitpaulk rohitpaulk merged commit 8ace23d into master May 15, 2015
@chadwhitacre chadwhitacre deleted the fix-payments-table-semantics branch May 15, 2015 15:38
@chadwhitacre chadwhitacre mentioned this pull request May 15, 2015
Merged
@chadwhitacre
Copy link
Contributor

To be clear: this wasn't the reason why we have no payments, correct?

@chadwhitacre
Copy link
Contributor

This bug is unrelated to that, yes?

@rohitpaulk
Copy link
Contributor Author

this wasn't the reason why we have no payments, correct?
This bug is unrelated to that, yes?

Yes, and yes. :)

@chadwhitacre
Copy link
Contributor

k :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohitpaulk @chadwhitacre