Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Fixed the bottom footer. Made it fixed on scrolling. #3339

Closed
wants to merge 1 commit into from

Conversation

kaguillera
Copy link
Contributor

Please review if this is what you want for #3331 @techtonik

@techtonik
Copy link
Contributor

I am still struggling to get my working environment at #3165, so I can't test ATM.

@kaguillera
Copy link
Contributor Author

No problem

@techtonik
Copy link
Contributor

There is still a scrollbar even when there is no content.

gratipay_-_scrollbar

@kaguillera
Copy link
Contributor Author

What browser are you using. I may have to test it on all (or as much as I possibly can)

@techtonik
Copy link
Contributor

I have only Chrome and Firefox, and I believe that was Chrome. In any case it seems that the issue is caused by the way the header is added to the page, because the height of scrolled area looks equal to header height.

@techtonik
Copy link
Contributor

Also, fixed border may eat up precious space on mobile devices. So it would be nice to just fix the screen height calculation to avoid the margin / padding / whatever makes this taller than it is.

@techtonik techtonik removed the Review label May 2, 2015
@techtonik
Copy link
Contributor

@kaguillera
Copy link
Contributor Author

!m @techtonik I wil try it

@techtonik
Copy link
Contributor

@kaguillera, go ahead! =)

I played a bit with CSS table layout in Google Chrome dev tools, but I am not sure how it will work in other browsers. I gave a display:table, moved fixed size <header> and <footer> out of #wrapper (I don't know why as extra #wrapper is needed there), and set display:table-row on them. Then I have to wrap central #main into additional <div>, because #main should be a display:table for managing central columns height to 100%, and top level needs display:table-row to redistribute its height among children.

I also used border-collapse: collapse on body table, because border became invisible. And then there was something to do with bottom footer to fix content alignment due to changed model from div to table row.

@chadwhitacre
Copy link
Contributor

Obsolete with #3718 .

@chadwhitacre chadwhitacre deleted the fix-footer branch September 1, 2015 04:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants