This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Count team takes in receiving amounts of participants #2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
They shouldn't be combined; we should have two separate numbers. We shouldn't devalue direct gifts people receive. |
|
@seanlinsley They're not combined in the DB, feel free to open another PR to show them separately in the UI. |
|
Added a test to prevent regressions. |
Changaco
changed the title
Changaco
changed the title
|
Test suite passes for me. |
|
Now to understand what is going on here ... :-) |
|
Okay, took a first pass through the code. Now to stand it up and understand what difference it makes in the UI. |
Closer to reality.
The team name knob was never actually used.
We're at 100 char lines now.
Before we were hardwiring 'alice' as the only team member that we would set a previous take for. I want to write tests for the interaction between takes for multiple member, so I need to be able to set take_last_week for multiple members.
When a member changes their take it affects the computed `takes` for all other team members.
Including one for including takes in receiving.
|
We talking in IRC about renaming the |
chadwhitacre
added a commit
that referenced
this pull request
Jun 17, 2014
Count team takes in receiving amounts of participants
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1139, one more step towards fixing #1127.