Implement option to hide total receiving from others (issue #1683) #1847
Conversation
|
Hey anyone having more experience with front end & jinja2 stuff - care to merge master into this branch? It seems a lot has changed. I am seeing 6 conflicts while trying to merge |
|
@zwn You should ping specific people, shouldn't you? ;-) |
|
This feels silly but why not @rummik @clone1018 @seanlinsley @Changaco @galuszkak - anyone up to it? |
|
I'm working to get this PR back up to date. |
|
Sorry about that, just arrived back in Dallas. Please continue to work on this, I wont be able to get my work (only a small amount) from my laptop anytime soon. Sorry about that. |
|
Rebase done. Let's make it the last, someone please review and merge before another becomes necessary. |
| {% set receiving = participant.get_dollars_receiving() %} | ||
|
|
||
| {% if giving > receiving and not participant.anonymous %} | ||
| {% if anon_giving and anon_receiving %} |
There was a problem hiding this comment.
This replaces our "USERNAME JOINED RECENTLY" text with "USERNAME gives and receives anonymously", shouldn't we only show that if the user is giving/receiving something?
There was a problem hiding this comment.
That would leak the information that the giving and receiving amounts are zero. Anonymous users might not expect or want that.
|
I tested most of the added functionality, I don't know how communities function yet as I can't easily test that. I also haven't been following up on the discussion of this so I wont be merging it in. |
ghost
assigned 
|
I'll review & merge this one later today. I take it that we are good on the UI side, right @clone1018? |
I am moving this to a new PR from a local branch so that more people can work on it. Original PR was #1721.