This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Remove the Horn #1776
Merged
Remove the Horn #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
I think we need to talk about this more. I guess we should talk about it over on #1466. |
|
I'm closing this in favor of testing our #1777 before we do anything rash. |
|
Reopening. #1777 isn't ready to merge yet. Still need to decide on which direction we're taking. |
|
Per IRC, we decided to drop the feature from code but leave the data in the database for now. If we get pushback and/or otherwise decide we need some kind of comments feature we can recover. |
chadwhitacre
added a commit
that referenced
this pull request
Dec 17, 2013
With the horn gone in #1776 we don't want to show nav w/ only one button.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been wanting to remove the horn for months, it doesn't fit into gittip's product scope.
Fixes: #1466
I'd also like to figure out if we want to deprecate this first instead of just pulling all support for it, let me know your thoughts.