Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

MassPay #1582

Merged
merged 7 commits into from
Oct 11, 2013
Merged

MassPay #1582

merged 7 commits into from
Oct 11, 2013

Conversation

chadwhitacre
Copy link
Contributor

Here's a first pass at a script to help with MassPay (#943).

I didn't like posting to Gittip in the same loop as I was computing the
CSV to upload to PayPal. I want a little more control over the process
at this point.
@chadwhitacre
Copy link
Contributor Author

The one missing link is the user's PayPal email address. Currently I've been handling that manually, storing it variously in Twitter DMs, email, support@, the History page, and my head. I propose that we add a single field to the participants table to track that info (unlogged). No UI for it. I'll manually update it as necessary.

The purpose of this field is to record a PayPal email address for people
whom we're paying out via MassPay. Since MassPay isn't intended as a
long-term option, I'm proposing that we don't need a UI for this field.
I'll update it manually via psql as needed. Generally I hear from people
on [email protected]. I confirm the email address manually by asking
for the first eight digits of their API key.
@chadwhitacre
Copy link
Contributor Author

This is ready for review and merge.



def compute_output_csvs():
total_gross = total_fees = total_net = D('0.00')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant, no?

@zbynekwinkler
Copy link
Contributor

Looks good, how do I test it?

@zbynekwinkler
Copy link
Contributor

Maybe some comment at the start of the file about why it is there, inputs, outputs etc. What do you think?

zbynekwinkler added a commit that referenced this pull request Oct 11, 2013
@zbynekwinkler zbynekwinkler merged commit 6b7ecc8 into master Oct 11, 2013
@zbynekwinkler zbynekwinkler deleted the masspay branch October 11, 2013 18:14
@chadwhitacre
Copy link
Contributor Author

!m @zwn

Here's where we decided to merge despite lack of automated tests:

https://botbot.me/freenode/gittip/msg/6824592/

tl;dr This is a one-off, babysat process. If anything goes wrong I'll be watching closely and I'll be the one who has to fix it. And this is way better than the manual process I've been using up to now, and we have bigger fish to fry.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants