Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

modify payday to not process gifts to participants with goal < 0 #916

Closed
chadwhitacre opened this issue May 2, 2013 · 3 comments · Fixed by #2517
Closed

modify payday to not process gifts to participants with goal < 0 #916

chadwhitacre opened this issue May 2, 2013 · 3 comments · Fixed by #2517
Labels
★★☆

Comments

@chadwhitacre
Copy link
Contributor

Over on #893 I started using goal < 0 to mean "no tips, please." I want to keep any existing tips in the database for cases of accidental change or mind change. But we shouldn't actually process any tips to patrons-no-tips.
@chadwhitacre chadwhitacre mentioned this issue May 2, 2013
Closed
This was referenced Sep 16, 2013
Closed
Closed
@chadwhitacre
Copy link
Contributor Author

Should we watch for this in self check (#1768)?

@zbynekwinkler
Copy link
Contributor

What would actually be the thing to check? Something like "if this week goal is < 0 there should not be any transfer"? Or something else?

@chadwhitacre
Copy link
Contributor Author

Yes, if goal < 0 then don't transfer any money to them.

This was referenced Jun 21, 2014
Closed
Merged
Changaco added a commit that referenced this issue Jul 17, 2014
@Changaco
failing test for #916
39766c9
Changaco added a commit that referenced this issue Jul 17, 2014
@Changaco
don't transfer tips to participants who don't want to receive them
c1cf8d1 
fixed #916
@Changaco Changaco reopened this Jul 17, 2014
Changaco added a commit that referenced this issue Jul 28, 2014
@Changaco
failing test for #916
5b7e216
Changaco added a commit that referenced this issue Jul 28, 2014
@Changaco
don't transfer tips to participants who don't want to receive them
058c925 
fixed #916
Changaco added a commit that referenced this issue Jul 29, 2014
@Changaco
failing test for #916
344ea4b
Changaco added a commit that referenced this issue Jul 29, 2014
@Changaco
don't transfer tips to participants who don't want to receive them
6e1688b 
fixes #916
Changaco added a commit that referenced this issue Jul 31, 2014
@Changaco
failing test for #916
9fb5797
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
★★☆
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patron no tips gratipay/gratipay.com
3 participants
@chadwhitacre @zbynekwinkler @Changaco