Gittip should respect patron-no-tips setting and existing tips should be cancelled

[mvdkleijn]

If a patron (or rather Gittip user) decides NOT to accept tips, Gittip should inform the user that his existing tips will be cancelled too.

Reasoning: a patron can decide between "I'm here as a patron" and the very explicit ".. and politely decline to receive gifts". This means the patron is making a conscious decision which Gittip and givers should respect. (though we can ask "are you sure?")

Existing flow:

• Team A signs up and accepts tips
• User B starts tipping Team A
• Team A becomes "no tips, thanks" patron
• Team A still receives tips from User B

Proposed flow:

• Team A signs up and accepts tips
• User B starts tipping Team A
• Team A becomes "no tips, thanks" patron
• Gittip UI asks "are you sure?"
• Gittip UI informs Team B that existing tips are cancelled.
• Team A no longer receives tips from User B
• User B is notified that Team A has decided to (start to) decline gifts and the user's gifts for the team have been reset to 0.

[chadwhitacre]

cf. #916 #917 #918

[mvdkleijn]

@whit537 yes, those items are indeed related, but I don't feel they cover this part so I explicitly pointed this out. I believe this behavior is very important in terms of fairness of the Gittip system.

[chadwhitacre]

I agree that this is a good idea, distinct from the others.

@mvdkleijn Since this includes user-visible changes, does it belong in Infrastructure?

[mvdkleijn]

@whit537 Agreed - Infra.

[mvdkleijn]

Or rather, it should be infra since it it related to the core behaviour around tipping. User visible changes are inevitable, but that doesn't mean its not infra related.

[chadwhitacre]

@mvdkleijn "Related to the core behaviour around tipping" is not the guideline for the Infrastructure milestone:

Issues in focus include development infrastructure (tooling, testing, developer docs, refactoring, build and deployment) and administrative infrastructure (organizational processes, legal, finance). The guideline is that any user-visible change is out of focus.

I'm not seeing that this ticket fits the criteria for the Infrastructure milestone.

[mvdkleijn]

OK, we'll remove it. Though I believe it shouldn't go unfixed too long. (bad press idea)

[codebykat]

I just changed my account to "politely decline" and was surprised to see that it didn't cancel tips I am receiving. I no longer wish to receive tips on Gittip*, but would like to continue giving them to others.

( *Chad's blog posts this week were the catalyst, but additionally I have a full-time job now that explicitly frowns on us taking side work, and I don't want to run afoul of that, so I've been meaning to disallow receiving for some time.)

Is there a workaround right now? If I cancel my account, am I able to open a new one that is still associated with my Twitter and Github accounts, and then redo all my tips?

[Changaco]

@codebykat Instead of a workaround I've started working on a proper fix for this issue (#2517).

[seanlinsley]

#2517 has been deployed to production; @codebykat the tips you were receiving have been canceled.

[codebykat]

Awesome! Thanks for the quick response on this.