Remove email notifications related to pledging

Sorry, @rohitpaulk. :-(

gratipay/models/account_elsewhere.py

@@ -233,7 +233,6 @@ def opt_in(self, desired_username):
         else:
             newly_claimed = True
             user.participant.set_as_claimed()
-            user.participant.notify_patrons(self)
             try:
                 user.participant.change_username(desired_username)
             except ProblemChangingUsername:

gratipay/models/participant.py

@@ -658,19 +658,6 @@ def render(t, context):
         self._mailer.messages.send(message=message)
         return 1 # Sent
 
-    def notify_patrons(self, elsewhere, tips=None):
-        tips = self.get_tips_receiving() if tips is None else tips
-        for t in tips:
-            p = Participant.from_username(t.tipper)
-            if p.email_address and p.notify_on_opt_in:
-                p.queue_email(
-                    'notify_patron',
-                    user_name=elsewhere.user_name,
-                    platform=elsewhere.platform_data.display_name,
-                    amount=t.amount,
-                    profile_url=elsewhere.gratipay_url,
-                )
-
     def queue_email(self, spt_name, **context):
         self.db.run("""
             INSERT INTO email_queue
@@ -1602,8 +1589,6 @@ def take_over(self, account, have_confirmation=False):
                 # this is a no op - trying to take over itself
                 return
 
-            # Save old tips so we can notify patrons that they've been claimed
-            old_tips = None if other.is_claimed else other.get_tips_receiving()
 
             # Make sure we have user confirmation if needed.
             # ==============================================
@@ -1740,9 +1725,6 @@ def take_over(self, account, have_confirmation=False):
         if new_balance is not None:
             self.set_attributes(balance=new_balance)
 
-        if old_tips:
-            self.notify_patrons(elsewhere, tips=old_tips)
-
         self.update_avatar()
 
         # Note: the order matters here, receiving needs to be updated before giving

sql/branch.sql

@@ -1,5 +1,6 @@
 BEGIN;
 
     ALTER TABLE participants DROP COLUMN pledging;
+    ALTER TABLE participants DROP COLUMN notify_on_opt_in;
 
 END;

www/~/%username/settings/index.html.spt

@@ -205,11 +205,6 @@ emails = participant.get_emails()
         <div class="email-notifications">
             <span>{{ _("Send me notifications via email:") }}</span>
             <br />
-            <label>
-                <input type="checkbox" data-field="notify_on_opt_in"
-                    {{ 'checked' if participant.notify_on_opt_in }} />
-                    {{ _("When people I pledge to join Gratipay") }}
-            </label>
             <div>
                 {{ _("When my credit card is charged:") }}
                 <br />