feature: signed account access #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissarmytowel
changed the title
|
Gas usage comparison:
|
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 80.16% 80.67% +0.51%
==========================================
Files 8 9 +1
Lines 746 771 +25
Branches 181 185 +4
==========================================
+ Hits 598 622 +24
+ Misses 70 69 -1
- Partials 78 80 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dsshap
reviewed
Sep 25, 2023
dsshap
requested changes
Sep 25, 2023
… storage and their setting to initializer
dsshap
reviewed
Oct 4, 2023
dsshap
reviewed
Oct 4, 2023
dsshap
reviewed
Oct 4, 2023
dsshap
reviewed
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds functionality to set allowed executions on behalf of the account with the signed message verification.
Bumps
core-cashandcore-physicalto the latest commits.Details
Implements account access setter for
_accountand_actor. Access granted is reliant on the signature contents and checks recovered address against the_account, it can be called by anyone as long as the passed signature is correct and was signed by the_accountprivate key which is a confirmation that the_accountallowed thisGuarded against replay attacks by using nonces.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshotforge fmtforge test