Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP Rewrite Step 2: refactor for @graphql-tools #3556

Draft
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

acao
Copy link
Member

@acao acao commented Mar 12, 2024

this gets us most of the way, just one integration suite assertion failing and some ts bugs. it needs a lot more work to be ready. the preceeding PR happens first of course

one of the end goals of this PR is also network schema invalidation :)) yes that's right, code first for all!

this also sets us up nicely for adding multi-root workspaces support, as we are reducing CPU and memory usage heavily in this PR, and this also provides a cleaner interface for MessageProcessor to support it

TODO:

  • use LRU cache to lazily invalidate remote schema cache, and rewrite cached file
  • create a custom "virtual file" loader to handle file changes that aren't reflected in the filesystem

Copy link

changeset-bot bot commented Mar 12, 2024

⚠️ No Changeset found

Latest commit: 7839f79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@acao acao changed the title fix: refactor for @graphql-tools LSP Rewrite Step 2: refactor for @graphql-tools Mar 17, 2024
@acao acao added the lsp-server graphql-language-service-server label Mar 17, 2024
@acao acao force-pushed the refactor-graphql-tools branch from a608668 to 7839f79 Compare March 17, 2024 09:45
@acao acao force-pushed the recent-missing-coverage branch from e8654b6 to 76c0d91 Compare April 7, 2024 11:35
@acao acao force-pushed the recent-missing-coverage branch from f24bb65 to ea57543 Compare May 1, 2024 12:09
@acao acao force-pushed the recent-missing-coverage branch 7 times, most recently from 0496caa to 203a2c0 Compare May 19, 2024 22:25
@acao acao force-pushed the recent-missing-coverage branch 2 times, most recently from fb7d418 to e5ab31e Compare May 27, 2024 19:43
Base automatically changed from recent-missing-coverage to main May 28, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lsp-server graphql-language-service-server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant