BugFix: Nested List Input Coercion not matching GraphQL spec

[abhinand-c]

This PR fixes the issue of Nested List Input with multiple values not being properly validated as per the schema.

For a nested List [[Int!]], providing an input value of [1, 2, 3]
Expected Behaviour: should raise validation error
Current Behaviour: coerce value to [ [1], [2], [3] ]

Changes

• Adds check to validate and raises error for the condition
• Updated tests to reflect the new logic, and validate error

Refer:

• https://spec.graphql.org/October2021/#sec-List.Input-Coercion

[Cito]

Hi @abhinand-c , and thank you for reporting and providing a fix. May I suggest that next time you create an issue before posting a PR ? We can then discuss what's the best way to solve the problem before you invest too much time.

I believe you're right in that the coercion rule (coercion needs to be distinguished from validation) is not properly implemented according to the latest spec. The implementation was correct regarding the older spec of 2016, but it looks like in 2018 the spec was changed, and this change was not incorporated into GraphQL.js of which GraphQL-core is a port.

The proper procedure to fix this is to open an issue for GraphQL.js, maybe followed by a PR with a fix for TypeScript, and when this is merged into GraphQL.js, the same fix will be ported to Python. By following this procedure we make sure the code base does not deviate, the JavaScript users benefit as well, and we can have a discussion with the larger JavaScript community and GraphQL experts on what's the best way to fix it and review the PR.

Let me know if you want to take care of that, or if you want me to do it and if I can take your code as a base for a possible PR in GraphQL.js.

[abhinand-c]

Hi @Cito , thanks for the guiding me in the right way, I'll definitely follow the proper procedure next time. I have raised the issue in GraphQL.js (graphql/graphql-js#3858).

Also, currently in this PR my commits were not signed, shall I proceed to update my commits and sign them?
Is there anything else that I should have taken care of as a first time contributor here?

[Cito]

No worries @abhinand-c it's all well. GraphQL.js is our upstream project. The guidelines for contributing to GraphQL.js are these if you want to create a PR there, but here we are a bit more relaxed.

[abhinand-c]

Hi, I have updated old (unsigned) commits and replaced them with signed commits by force pushing.

[erikwrede]

Upstream update: graphql/graphql-spec#1057 (comment)

Once the spec PR is merged, we can close this PR, as the table this relied on was adjusted to allow our explicit case.

[abhinand-c]

Closing this PR as spec was updated to clarify the isssue, and no change in implementation is required.

Ref:

• Nested List Input Coercion not matching GraphQL spec graphql/graphql-js#3858 (comment)
• Fix coercion table for list graphql/graphql-spec#1057