Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: db locked error #143

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix: db locked error #143

merged 1 commit into from
Apr 24, 2024

Conversation

pete-eiger
Copy link
Contributor

@pete-eiger pete-eiger commented Apr 24, 2024

Attempted fix for the db locked error.

@pete-eiger pete-eiger force-pushed the petko/fix-db-locked-error branch from fdd73d5 to 056b2e6 Compare April 24, 2024 16:17
@pete-eiger pete-eiger requested a review from hopeyen April 24, 2024 17:35
Copy link
Collaborator

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see what happens

.run(&pool)
.await
.expect("Could not run migration");
black_box(());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you explain what motivated this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was clippy's doing (cargo clippy --fix)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why that is. probably remove black_box(()); because it is useless if nothing is contained inside

@pete-eiger pete-eiger merged commit 0a467b2 into dev Apr 24, 2024
11 checks passed
@pete-eiger pete-eiger deleted the petko/fix-db-locked-error branch April 24, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants