Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client payments #43

Merged
merged 8 commits into from
Jan 31, 2024
Merged

client payments #43

merged 8 commits into from
Jan 31, 2024

Conversation

hopeyen
Copy link
Collaborator

@hopeyen hopeyen commented Jan 26, 2024

Description

  • added escrow contract functions and CLI commands to deposit and withdraw
  • decode contract error when reverted
  • construct dumb receipts and send with query request
  • downloaders can approve Escrow contract for GRT spending if it is their first time using the contract
  • updated docs

for later PR:

  • indexer cost model (by porting to indexer-rs)
  • more reasonable receipt fee calculations
  • indexer allocation id discovery
  • e2e payments testing with mocked contracts

Issue link (if applicable)

#21

Checklist

  • Are tests up-to-date with the new changes?
  • Are docs up-to-date with the new changes? (Open PR on docs repo if necessary)

@hopeyen hopeyen marked this pull request as draft January 26, 2024 23:30
@hopeyen hopeyen self-assigned this Jan 26, 2024
@hopeyen hopeyen added size:large Large p1 High priority type:feature New or enhanced functionality labels Jan 26, 2024
Copy link

Pull Request Test Coverage Report for Build 7674551140

  • -201 of 201 (0.0%) changed or added relevant lines in 10 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.9%) to 37.17%

Changes Missing Coverage Covered Lines Changed/Added Lines %
file-exchange/src/errors.rs 0 1 0.0%
file-exchange/src/download_client/signer.rs 0 2 0.0%
file-exchange/src/discover/mod.rs 0 3 0.0%
file-exchange/src/graphql/mod.rs 0 3 0.0%
file-exchange/src/transaction_manager/staking.rs 0 7 0.0%
file-exchange/src/config.rs 0 8 0.0%
file-exchange/src/main.rs 0 10 0.0%
file-exchange/src/transaction_manager/mod.rs 0 21 0.0%
file-exchange/src/download_client/mod.rs 0 43 0.0%
file-exchange/src/transaction_manager/escrow.rs 0 103 0.0%
Files with Coverage Reduction New Missed Lines %
file-exchange/src/transaction_manager/mod.rs 3 0.0%
Totals Coverage Status
Change from base Build 7671578314: -1.9%
Covered Lines: 1043
Relevant Lines: 2806

💛 - Coveralls

@hopeyen hopeyen marked this pull request as ready for review January 31, 2024 16:40
@hopeyen hopeyen merged commit 449b25b into dev Jan 31, 2024
5 checks passed
@hopeyen hopeyen deleted the hope/client-wallet branch January 31, 2024 16:41
@hopeyen hopeyen linked an issue Jan 31, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 High priority size:large Large type:feature New or enhanced functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Client wallet connection and dumb TAP payment
1 participant