Code

Simplify round, fix directed rounding#24

Code

Merged

awf merged 15 commits intomaingraphcore-research/gfloat:mainfrom simplify-roundgraphcore-research/gfloat:simplify-roundCopy head branch name to clipboardJun 6, 2024

+315-57

Commits

Commits on Jun 5, 2024

• Simplify logic in "round"

  awf

  committed
  5904633

• Simplify rounding logic

  awf

  committed
  4635f5e

• more readability

  awf

  committed
  b1c61c8

• Doc fixes

  awf

  committed
  146e90e

• Add failing test

  awf

  committed
  29e5564

• Fix round to Positive, Negative

  awf

  committed
  2d3e954

• Fix Toward* for P=1

  awf

  committed
  f263a7a

• Add tests, fix logic near zero, and directed

  awf

  committed
  e669724

• More tests

  awf

  committed
  8d03afe

• Check both sats

  awf

  committed
  8793f7e

• Oh my, py

  awf

  committed
  980b494

• nits

  awf

  committed
  6e35def

Commits on Jun 6, 2024

• PR Comment

  awf

  committed
  c10d3fa

• Attempt to resolve https://github.com/graphcore-research/gfloat/pull/24/files#r1628019184

  awf

  committed
  ba39703

• Revert "Attempt to resolve https://github.com/graphcore-research/gfloat/pull/24/files#r1628019184"

  Show description for 1ecf411
  awf

  committed
  1ecf411