Support for include and skip directive with references #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CNAChino
reviewed
Nov 8, 2023
| @@ -91,6 +93,12 @@ public TraversalControl visitField(Field node, TraverserContext<Node> context) { | |||
| requireNonNull(fieldDefinition, "Failed to get Field Definition for " + node.getName()); | |||
|
|
|||
| context.setVar(GraphQLType.class, fieldDefinition.getType()); | |||
|
|
|||
There was a problem hiding this comment.
Can we also add integration test i.e. send query to graphql orchestrator and validate the outgoing query.
kmoore-intuit
force-pushed
the
query-directive-remove-node
branch
2 times, most recently
from
b1ea37c to
07f3bba
Compare
CNAChino
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Why
Todo: