Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] joint_buying_account : Add the wizard to generate commission in… #92

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

legalsylvain
Copy link
Member

@legalsylvain legalsylvain commented Feb 2, 2024

No description provided.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 88.31169% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 90.14%. Comparing base (5f32b39) to head (bb3122e).
Report is 8 commits behind head on 12.0.

Files Patch % Lines
...rds/joint_buying_invoice_commission_wizard_line.py 80.59% 6 Missing and 7 partials ⚠️
.../wizards/joint_buying_invoice_commission_wizard.py 86.84% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             12.0      #92      +/-   ##
==========================================
- Coverage   90.19%   90.14%   -0.06%     
==========================================
  Files         103      109       +6     
  Lines        3131     3276     +145     
  Branches      534      559      +25     
==========================================
+ Hits         2824     2953     +129     
- Misses        251      259       +8     
- Partials       56       64       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legalsylvain legalsylvain force-pushed the 12.0-IMP-joint_buying_account-invoice-suppliers branch from 75458dd to a20a3b6 Compare March 13, 2024 23:33
@legalsylvain legalsylvain force-pushed the 12.0-IMP-joint_buying_account-invoice-suppliers branch 3 times, most recently from a66f92d to 6d44219 Compare March 14, 2024 14:48
@legalsylvain legalsylvain marked this pull request as ready for review March 14, 2024 17:59
do not call _compute_grouped_order_ids_model twice;
Improve speed of _compute_grouped_order_ids_model execution
Allow to edit commission rate in the wizard
@legalsylvain legalsylvain force-pushed the 12.0-IMP-joint_buying_account-invoice-suppliers branch from 6d44219 to b954c2e Compare March 15, 2024 12:32
[ADD] commission invoice on grouped order form view
[IMP] improve commission invoice line text
@legalsylvain
Copy link
Member Author

Mep du 17/03/2024

/ocabot merge minor

@github-grap-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-92-by-legalsylvain-bump-minor, awaiting test results.

@github-grap-bot github-grap-bot merged commit 3bfd7da into 12.0 Mar 19, 2024
2 of 4 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 6e56221. Thanks a lot for contributing to grap. ❤️

@github-grap-bot github-grap-bot deleted the 12.0-IMP-joint_buying_account-invoice-suppliers branch March 19, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants