Refactor and optimize filters #1792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: stevenyoungs <[email protected]>
|
I'm going to close this PR and open one not based on any SQL access |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors (and fixes) many issues in the filter system. The initial fix was just unrolling recursive calls to be less expensive.
Next, instead of automatically creating an Gramps object for each line, JSON data is passed to the rules. Some rules will still require an object, but it is only created when needed, and only created once per row. This results in a large speed-up from before (like 30%).
Finally, a set of optimizations are added to make the filters superfast. This uses the conventions already created in Gramps: some expensive filters create a map and use that to see if the object matches. We turn the filter operation inside out, using the maps to narrow down the items considered. This can take operations that took minutes into ones that can be done in a few seconds.
On overview can be read here: https://gramps.discourse.group/t/making-gramps-filters-faster-and-then-superfast/6460/7