[common] Refactor Protected Files, part 8 #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimakuv
force-pushed
the
dimakuv/protected-files-cleanup-new-part8
branch
from
1d72649 to
ee92d85
Compare
Base automatically changed from
dimakuv/dimakuv/protected-files-cleanup-new-part7
to
master
June 19, 2024 14:40
mkow
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
kailun-qin
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
This commit refactors PF code without changing functionality (part 8 in a series of commits). In particular, this commit renames: - "plain_part" to more specific "plaintext_part" - "metadata_encrypted_t" to "metadata_decrypted_t" - all instances of "gmac" to "mac" Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
dimakuv
force-pushed
the
dimakuv/protected-files-cleanup-new-part8
branch
from
ee92d85 to
629c413
Compare
kailun-qin
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
This commit refactors PF code without changing functionality (part 8 in a series of commits). In particular, this commit renames:
This PR supersedes #1894.
How to test this PR?
N/A.
This change is