-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ROS2 ActionClient w/ limited functionality #125
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great to me -- just a few minor formatting things and I think this V1 support will be a great addition. Thank you!
Hi! I already fixed your suggested minor changes. Thanks. |
Sorry, but I'm not a maintainer of this repo so I can't actually approve your changes. I was just looking because I implemented the rosbridge side of this work. |
Sorry @danmartzla, I forgot to mention that I recently landed a small change to the protocol that allows for cleaner action cancellation. It may require a small change since now the Also @gonzalocasas Would you be able to review this PR? |
Added the roslibpy.ActionClient object to send actions goals to ROS2-based systems.
This implementation has limited capabilities (related to RobotWebTools/rosbridge_suite#909) such as:
What type of change is this?
Checklist
CHANGELOG.rst
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke check
).