Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ROS2 ActionClient w/ limited functionality #125

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

danmartzla
Copy link

@danmartzla danmartzla commented Jun 30, 2024

Added the roslibpy.ActionClient object to send actions goals to ROS2-based systems.
This implementation has limited capabilities (related to RobotWebTools/rosbridge_suite#909) such as:

  • Goal cancelation is not functional.
  • Goal rejection/acceptance are not being notified to the Action client.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

  • I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke check).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me -- just a few minor formatting things and I think this V1 support will be a great addition. Thank you!

docs/files/ros2-action-client.py Show resolved Hide resolved
docs/files/ros2-action-client.py Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
@danmartzla
Copy link
Author

This all looks great to me -- just a few minor formatting things and I think this V1 support will be a great addition. Thank you!

Hi! I already fixed your suggested minor changes. Thanks.

@sea-bass
Copy link

sea-bass commented Oct 2, 2024

Sorry, but I'm not a maintainer of this repo so I can't actually approve your changes. I was just looking because I implemented the rosbridge side of this work.

@sea-bass
Copy link

sea-bass commented Oct 3, 2024

Sorry @danmartzla, I forgot to mention that I recently landed a small change to the protocol that allows for cleaner action cancellation. It may require a small change since now the action_result message also contains a status field telling you whether the action was successful, canceled, aborted, etc.: RobotWebTools/rosbridge_suite#953

Also @gonzalocasas Would you be able to review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants