Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stdlib): Add toList, fromList, toArray, fromArray to Stack #2198

Merged
merged 4 commits into from
Jan 2, 2025
Merged

feat(stdlib): Add toList, fromList, toArray, fromArray to Stack #2198

merged 4 commits into from
Jan 2, 2025

Conversation

spotandjake
Copy link
Member

@spotandjake spotandjake commented Nov 17, 2024 •
edited
Loading

This pr adds toList, fromList, toArray, fromArray to both the Stack and Stack.Immutable modules.

@spotandjake spotandjake self-assigned this Nov 17, 2024
ospencer
ospencer reviewed Dec 29, 2024
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you match these changes for the Immutable submodule as well?

stdlib/stack.gr Outdated Show resolved Hide resolved
stdlib/stack.gr Outdated Show resolved Hide resolved
@ospencer ospencer enabled auto-merge January 2, 2025 20:42
@ospencer ospencer added this pull request to the merge queue Jan 2, 2025
Merged via the queue into grain-lang:main with commit b815bcd Jan 2, 2025
12 checks passed
@github-actions github-actions bot mentioned this pull request Jan 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ospencer ospencer ospencer approved these changes

@phated phated Awaiting requested review from phated phated is a code owner

@peblair peblair Awaiting requested review from peblair peblair is a code owner

@marcusroberts marcusroberts Awaiting requested review from marcusroberts marcusroberts is a code owner

@jozanza jozanza Awaiting requested review from jozanza jozanza is a code owner

@alex-snezhko alex-snezhko Awaiting requested review from alex-snezhko alex-snezhko is a code owner

Assignees

@spotandjake spotandjake

Labels
stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spotandjake @ospencer