Issue 12142 #12148
Issue 12142 #12148
Conversation
| // right now grails also breaks it up by also adding: | ||
| // "[a[0]:[b:1], a[1]:[b:2]]" | ||
| // Personally, I think that's useless, but whether you want to retain it, I don't know. | ||
| assert params != null |
There was a problem hiding this comment.
asserting that params is not null may not make sense here. In order for it to be null, the new GrailsParameterMap(request) would have to return null, and then a NullPointerException would have been thrown at line 504 I think. Is that correct?
There was a problem hiding this comment.
Sounds reasonable, I was just following the existing pattern.
|
|
|
@xpusostomos Thank you for taking time to send this pull request. I am a little confused that whether this is about adding a test for functionality which currently does not work? or it is just an addition of new test whereas the functionality is working fine? |
|
I raised an issue where I think grails should behave differently. I was asked to provide a pull request for a test case for how I think it should work. This I did here. |
See: #12142 (comment)