Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete agent integration tests #327

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Complete agent integration tests #327

merged 5 commits into from
Sep 12, 2023

Conversation

pablochacin
Copy link
Collaborator

@pablochacin pablochacin commented Aug 30, 2023 •
edited
Loading

Description

This PR completes the process stated in #322 and re-implement all existing agent "e2e" tests as integration tests using TestContainers, with the exception of the tests for pod forwarding that were moved to the disruptor e2e tests.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make test) and all tests pass.
  • I have run relevant e2e test locally (make e2e-xxx for agent, disruptors, kubernetes or cluster related changes)
  • Any dependent changes have been merged and published in downstream modules

@pablochacin pablochacin force-pushed the complete-agent-integration-tests branch from 0d16868 to 19c3ec0 Compare August 30, 2023 13:01
@pablochacin pablochacin force-pushed the complete-agent-integration-tests branch from 19c3ec0 to d55dc75 Compare August 30, 2023 13:36
@pablochacin pablochacin marked this pull request as ready for review August 30, 2023 13:46
@pablochacin pablochacin requested a review from roobre August 30, 2023 13:46
roobre
roobre approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@roobre roobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking and running great, also blazing fast. Awesome work :)

@pablochacin pablochacin merged commit 38a2343 into main Sep 12, 2023
6 checks passed
@pablochacin pablochacin deleted the complete-agent-integration-tests branch September 12, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roobre roobre roobre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablochacin @roobre