Add support for Graylog's Geolocation and other string field -based data sources #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a new Location Data option ("string"), which makes it possible
to query coordinates that are stored as a string in a single field.
The field should be formatted as "latitude,longitude".
Graylog's Geolocation plugin stores data this way instead of as a
geohash. This has made it difficult for Graylog users to use this plugin.
|
|
|
Dear Jani, may we humbly ask you to submit this PR to our grafana-map-panel fork? The vanilla Worldmap Panel has not been maintained for some time already. We would be happy to accept your contribution as we see it is valuable for the community. As the development has progressed on some ends, the update will probably need some adjustments. When already on it, it would be super cool to accompany your improvements using appropriate test cases. You will be able to find respective guidelines within CONTRIBUTING.md. With kind regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use Graylog's Geolocation plugin data as a source. The location data is by default stored as a single string ("latitude,longitude"), which this plugin doesn't support yet. So far matching the country data has been the only solution for Graylog users, but coordinates would provide a lot more accurate data.
This pull request adds a new location data option, which makes it possible to use Graylog's Geolocation data as the source without breaking any existing features.
There's been a lot of discussion around the internet about this issue, but not a single proper solution.
Fixes #41