Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Wait for All Queries" toggle #313

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix "Wait for All Queries" toggle #313

merged 1 commit into from
Oct 9, 2024

Conversation

idastambuk
Copy link
Contributor

Fixes #276

@idastambuk idastambuk requested a review from a team as a code owner October 4, 2024 09:12
@idastambuk idastambuk requested review from kevinwcyu and nmarrs October 4, 2024 09:12
@iwysiu iwysiu mentioned this pull request Oct 7, 2024
Merged
nmarrs
nmarrs approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@nmarrs nmarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I was able to test and confirm fix locally 😎

Screen.Recording.2024-10-08.at.7.24.14.AM.mov

@idastambuk idastambuk merged commit 40c2c7b into main Oct 9, 2024
2 checks passed
@idastambuk idastambuk deleted the wait-switch branch October 9, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarrs nmarrs nmarrs approved these changes

@iwysiu iwysiu iwysiu approved these changes

@kevinwcyu kevinwcyu Awaiting requested review from kevinwcyu kevinwcyu is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query Editor: "Wait for All Queries" toggle is not shown toggled when its set
3 participants
@idastambuk @iwysiu @nmarrs