New Release Process (Semi automatic way) #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruben Vargas <[email protected]>
Signed-off-by: Ruben Vargas <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
=======================================
Coverage 78.22% 78.22%
=======================================
Files 65 65
Lines 5024 5024
=======================================
Hits 3930 3930
Misses 907 907
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frzifus
approved these changes
Nov 14, 2023
iblancasa
approved these changes
Nov 14, 2023
|
Good job! |
| jobs: | ||
| release: | ||
| if: | | ||
| github.event.pull_request.merged == true && github.event.pull_request.head.repo.full_name == github.repository | ||
| && github.event.pull_request.user.login == 'github-actions[bot]' && github.event.pull_request.user.type == 'Bot' |
There was a problem hiding this comment.
Can we also check if the source branch of the PR starts with releases/? Maybe we use this bot account for more things in the future, and this workflow should only run on releases.
startsWith(github.event.pull_request.head.ref, 'releases/')
andreasgerstmayr
approved these changes
Nov 14, 2023
Signed-off-by: Ruben Vargas <[email protected]>
Signed-off-by: Ruben Vargas <[email protected]>
rubenvp8510
force-pushed
the
release_improvments
branch
from
350d434 to
1b0df6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new process is as follows:
The release GitHub action will take place
This GH action will be triggered only when the PR that gets merged is from releases/*., the source and destination are the the same repository, and the author of the PR is a GitHub action.
And this workflow follows the regular process, created release on GH and create the tag (we don't need to create the tag manually anymore)
Also this will trigger the OLM publish but that work is on another PR. (#583)
@andreasgerstmayr @pavolloffay @frzifus @iblancasa Let me know what do you think.
PS. I'll update the RELEASE.md once this is accepted.