Skip to content

Commit

Permalink
Expose a single timeout setting in CRDs
Browse files Browse the repository at this point in the history
Signed-off-by: Pavol Loffay <[email protected]>
  • Loading branch information
pavolloffay committed Oct 3, 2024
1 parent 89f3de8 commit cd955da
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 14 deletions.
10 changes: 0 additions & 10 deletions apis/tempo/v1alpha1/tempostack_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -796,16 +796,6 @@ type QueryLimit struct {
MaxSearchDuration metav1.Duration `json:"maxSearchDuration"`
}

// TimeoutsSpec defines timeout limits for ingestion and query
type TimeoutsSpec struct {
// Read defines read timeout. It configures timeouts from ingress/route down to the querier.
// If a component uses a single configuration for read and write timeout the higher value will be applied.
Read metav1.Duration `json:"read"`
// Write defines write timeout. It configures timeouts from ingress/route down to the ingestor.
// If a component uses a single configuration for read and write timeout the higher value will be applied.
Write metav1.Duration `json:"write"`
}

// RetentionSpec defines global and per tenant retention configurations.
type RetentionSpec struct {
// PerTenant is used to configure retention per tenant.
Expand Down
3 changes: 2 additions & 1 deletion internal/manifests/config/options.go
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
package config

import (
"github.com/grafana/tempo-operator/internal/manifests/manifestutils"
"time"

"github.com/grafana/tempo-operator/internal/manifests/manifestutils"
)

// options holds the configuration template options.
Expand Down
5 changes: 3 additions & 2 deletions internal/manifests/queryfrontend/query_frontend.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ package queryfrontend

import (
"fmt"
"path"
"strings"

"github.com/imdario/mergo"
routev1 "github.com/openshift/api/route/v1"
"github.com/operator-framework/operator-lib/proxy"
Expand All @@ -12,9 +15,7 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
k8slabels "k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/util/intstr"
"path"
"sigs.k8s.io/controller-runtime/pkg/client"
"strings"

"github.com/grafana/tempo-operator/apis/tempo/v1alpha1"
"github.com/grafana/tempo-operator/internal/manifests/manifestutils"
Expand Down
3 changes: 2 additions & 1 deletion internal/manifests/queryfrontend/query_frontend_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ package queryfrontend

import (
"fmt"
"testing"

routev1 "github.com/openshift/api/route/v1"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
Expand All @@ -14,7 +16,6 @@ import (
k8slabels "k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/util/intstr"
"k8s.io/utils/ptr"
"testing"

configv1alpha1 "github.com/grafana/tempo-operator/apis/config/v1alpha1"
"github.com/grafana/tempo-operator/apis/tempo/v1alpha1"
Expand Down

0 comments on commit cd955da

Please sign in to comment.