Tracing: use events for http client detail #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otelhttptrace shows the time to do DNS, get a connection, etc. By default it does these as sub-spans, but I think it's better to do them as events. Smaller volume of data and easier to view on screen. Signed-off-by: Bryan Boreham <[email protected]>
alexander-akhmetov
approved these changes
Dec 16, 2024
|
@alexander-akhmetov thanks for approving; what is the process to get this merged? |
|
No problem! I'll merge it |
|
Updating the version in mimir: grafana/mimir#10366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otelhttptrace shows the time to do DNS, get a connection, etc. By default it does these as sub-spans, but I think it's better to do them as events. Smaller volume of data and easier to view on screen.
Example with subspans:
Example without subspans:
