mimir-distributed: allow StatefulSets to configure their PVC template names #10376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narqo
force-pushed
the
vldmr/helm-pvc-template-name
branch
from
db2b64a to
d452cf5
Compare
tacole02
reviewed
Jan 8, 2025
| @@ -31,6 +31,8 @@ Entries should include a reference to the Pull Request that introduced the chang | |||
|
|
|||
| * [CHANGE] Memcached: Update to Memcached 1.6.34. #10318 | |||
| * [ENHANCEMENT] Minio: update subchart to v5.4.0. #10346 | |||
| * [ENHANCEMENT] Alertmanager, compactor, ingester and store-gateway statefulsets can configure their PVC template name via the corresponding *.persistentVolume.name values. #10376 | |||
| * [ENHANCEMENT] Added option to enable StatefulSetAutoDeletePVC for StatefulSets for compactor, ingester, store-gateway, | |||
There was a problem hiding this comment.
for compactor, ingester, and store-gateway. ?
There was a problem hiding this comment.
This was a copy&paste from an old entry in the changelog. Now, 24 hours latter, I'm not sure why I did that. It's now gone, thank you for noticing 🙌
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
narqo
force-pushed
the
vldmr/helm-pvc-template-name
branch
from
9c396b4 to
57d3b02
Compare
tacole02
reviewed
Jan 10, 2025
tacole02
approved these changes
Jan 10, 2025
Co-authored-by: Taylor C <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR updates the chart StatefulSets templates, to allow configuring their PVC template names. E.g.
This is a noop change for the existing systems. But this'll allow us to minimise the discrepancies between the Jsonnet bundle and the Helm chart, when migrating our internal systems to use the chart.
Also, the PR simplifies the templates of the
volumeClaimTemplatesyaml sections.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.