Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Baidu Object Storage under supported Stores for chunks takes you to a Chinese website #9987

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

samu6851
Copy link

The Link to Baidu Object Storage under supported Stores for chunks takes you to a Chinese website.

I have put the proper link in my edit.

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

The Link to Baidu Object Storage under supported Stores for chunks takes you to a Chinese website.

I have put the proper link in my edit.
@CLAassistant
Copy link

CLAassistant commented Jul 19, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ JStickler
❌ samu6851
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jul 19, 2023
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM If you could please sign the CLA, we can merge this.

@JStickler JStickler requested a review from a team as a code owner December 4, 2023 21:15
@JStickler
Copy link
Contributor

@samu6851 Could you please sign the Contributor License Agreement (CLA)?

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Trivy scan found the following vulnerabilities:

@JStickler
Copy link
Contributor

@samu6851 if you could sign the CLA, we could merge this update.

@cstyan
Copy link
Contributor

cstyan commented Jan 5, 2024

@samu6851 bump, need to sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants