Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added list of supported scrapes to top of page to save reading the wh… #9058

Closed
wants to merge 4 commits into from

Conversation

Alex3k
Copy link
Contributor

@Alex3k Alex3k commented Apr 6, 2023

What this PR does / why we need it:
I have added list of supported scrapes to top of page to save reading the whole thing. This provides a simple way for me to provide a link to a list of supported inputs rather than ask customers to read the whole page. Much easier for sharing information

@Alex3k Alex3k added the Q1SE label Apr 6, 2023
@Alex3k Alex3k requested a review from JStickler as a code owner April 6, 2023 13:42
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 6, 2023
docs/sources/clients/promtail/scraping.md Outdated Show resolved Hide resolved
docs/sources/clients/promtail/scraping.md Outdated Show resolved Hide resolved
docs/sources/clients/promtail/scraping.md Outdated Show resolved Hide resolved
@GrafanaWriter GrafanaWriter removed the Q1SE label May 2, 2023
@MasslessParticle
Copy link
Contributor

Closing for inactivity

@Alex3k
Copy link
Contributor Author

Alex3k commented Jul 4, 2023

Why was this closed for inactivitiy @MasslessParticle ? I was waiting for someone to merge it

@Alex3k Alex3k reopened this Jul 4, 2023
@JStickler
Copy link
Contributor

@Alex3k Before it can be merged, this PR needs to be updated and the generated documentation needs to be updated by running 'make doc' and committing the changes.

@JStickler
Copy link
Contributor

@Alex3k Could you resolve the conflicts on this PR so we can get it merged?

@JStickler
Copy link
Contributor

Closing due to inactivity and merge conflicts, replaced by #11444 .

@JStickler JStickler closed this Dec 11, 2023
JStickler added a commit that referenced this pull request Dec 12, 2023
**What this PR does / why we need it**:
Replaces @Alex3k PR #9058 which has gone quite stale (file has moved,
new content has been added).

Adds a mini table of contents at the beginning of the page with links to
headings.
Rearranges the headings so that they are in alphabetical order.

**Special notes for your reviewer**:
Content below line 27 is unchanged and previously published, it has only
been moved in the file.
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
**What this PR does / why we need it**:
Replaces @Alex3k PR grafana#9058 which has gone quite stale (file has moved,
new content has been added).

Adds a mini table of contents at the beginning of the page with links to
headings.
Rearranges the headings so that they are in alphabetical order.

**Special notes for your reviewer**:
Content below line 27 is unchanged and previously published, it has only
been moved in the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants