Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update-python-version-for-helm-ci #15420

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

GVengelen
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
This issue resolves failing ci, python 3.7 is depricated and not supported in ubuntu 24.04. See thread here

Checklist

  • [ x] Reviewed the CONTRIBUTING.md guide (required)
  • [ x] Documentation added
  • [ x] Tests updated
  • [x ] Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • [x ] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [ x] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@GVengelen GVengelen requested a review from a team as a code owner December 15, 2024 06:31
@CLAassistant
Copy link

CLAassistant commented Dec 15, 2024

CLA assistant check
All committers have signed the CLA.

@@ -33,7 +33,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.7
python-version: 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use a stable release like 3.13? setup-python action also fails to pick this version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@GVengelen GVengelen changed the title fix:update-python-version-for-helm-ci fix: update-python-version-for-helm-ci Dec 16, 2024
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @GVengelen!

@chaudum chaudum merged commit bdbb009 into grafana:main Dec 16, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants