Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Reverting #11506 #15409

Merged
merged 1 commit into from
Dec 13, 2024
Merged

chore: Reverting #11506 #15409

merged 1 commit into from
Dec 13, 2024
+258 −1,027

Conversation

slim-bean
Copy link
Collaborator

in favor of #13057 the initial implementation was a 'clean room' implementation able to decode chunks without importing any Loki code, this update undid that implementation and we would prefer to keep it as a "clean room" type application

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@slim-bean
Reverting #11506 in favor of #13057 the initial implementation was a …
f9fe04d 
…'clean room' implementation able to decode chunks without importing any Loki code, this update undid that implementation and we would prefer to keep it as a "clean room" type application

Signed-off-by: Edward Welch <[email protected]>
@slim-bean slim-bean requested a review from a team as a code owner December 13, 2024 14:14
fcjack
fcjack approved these changes Dec 13, 2024
View reviewed changes
Copy link

@fcjack fcjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean slim-bean merged commit 07e4df8 into main Dec 13, 2024
60 checks passed
@slim-bean slim-bean deleted the revert-11506 branch December 13, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcjack fcjack fcjack approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slim-bean @fcjack