Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(block-scheduler): init record planner correctly #15390

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix(block-scheduler): init record planner correctly #15390

merged 1 commit into from
Dec 13, 2024
+49 −26

Conversation

ashwanthgoli
Copy link
Contributor

What this PR does / why we need it:

Record planner is not initialised correctly causing panics, this change inits it with all the required dependencies.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ashwanthgoli ashwanthgoli marked this pull request as ready for review December 12, 2024 13:33
@ashwanthgoli ashwanthgoli requested a review from a team as a code owner December 12, 2024 13:33
cyriltovena
cyriltovena approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashwanthgoli ashwanthgoli merged commit 117869f into main Dec 13, 2024
60 checks passed
@ashwanthgoli ashwanthgoli deleted the record-planner-init branch December 13, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashwanthgoli @cyriltovena