Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(block-scheduler): add scheduler grpc methods to auth mw ignore list #15388

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

ashwanthgoli
Copy link
Contributor

@ashwanthgoli ashwanthgoli commented Dec 12, 2024

What this PR does / why we need it

By default loki applies user header interceptor middleware for all grpc methods on the server side which tries to extract user information from grpc metadata. But block scheduler methods are internal and their functionality is not tied to a single user. Adding the scheduler methods to the ignore list to not fail in the interceptor.

Similarly grpcclient.Instrument() tries to extract user information from context to perform per-tenant instrumentation cauing these methods to fail. Updated the Dial opts to only include the required interceptors.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ashwanthgoli ashwanthgoli marked this pull request as ready for review December 12, 2024 12:24
@ashwanthgoli ashwanthgoli requested a review from a team as a code owner December 12, 2024 12:24
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashwanthgoli ashwanthgoli merged commit b353acf into main Dec 13, 2024
60 checks passed
@ashwanthgoli ashwanthgoli deleted the auth-ignore-block-scheduler branch December 13, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants