Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-promtail): Remove s3 bucket ownership verification #15383

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

milenpankov-bosch
Copy link
Contributor

@milenpankov-bosch milenpankov-bosch commented Dec 12, 2024

What this PR does / why we need it: Removes the s3 bucket ownership verification as it is not using an AWS account id for verification.

Which issue(s) this PR fixes:
Fixes #15382

@milenpankov-bosch milenpankov-bosch requested a review from a team as a code owner December 12, 2024 07:57
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

tools/lambda-promtail/lambda-promtail/s3.go Show resolved Hide resolved
@chaudum chaudum changed the title lambda-promtail: remove s3 bucket ownership verification fix(lambda-promtail): Remove s3 bucket ownership verification Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lambda-promtail: s3 bucket ownership verification not working
2 participants