Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: sandbox fix for quickstart (backport release-3.1.x) #15366

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Dec 11, 2024

Backport 16acdf6 from #15358


What this PR does / why we need it:
This is a quick fix to the changes added to the getting started demo:

  • Added setup script to upgrade docker-compose to the latest version in sandbox.
  • Removed out-of-date command

https://killercoda.com/grafana-dev-testing/course/loki/loki-quickstart

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@loki-gh-app loki-gh-app bot requested a review from a team as a code owner December 11, 2024 16:36
@loki-gh-app loki-gh-app bot added backport size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Dec 11, 2024
@loki-gh-app loki-gh-app bot requested a review from JStickler December 11, 2024 16:36
@JStickler JStickler merged commit 4637c56 into release-3.1.x Dec 11, 2024
60 of 63 checks passed
@JStickler JStickler deleted the backport-15358-to-release-3.1.x branch December 11, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants