Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Move from base-nossl to static (backport release-3.3.x) #15211

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Dec 2, 2024

Backport 5f670a4 from #15203


What this PR does / why we need it:
This PR removes the inclusion of glibc into most of the Docker images created by the Loki build system.

It excludes:

  • The loki-canary BoringCrypto image, as it requires glibc as part of the CGO dependency
  • The debug image for Loki, as it installs dlv, which in turn requires glibc

Which issue(s) this PR fixes:
This removes an unneeded dependency, which adds some low severity CVE items into the Docker images that we generate.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@loki-gh-app loki-gh-app bot added the area/helm label Dec 2, 2024
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner December 2, 2024 21:01
@loki-gh-app loki-gh-app bot added backport dependencies Pull requests that update a dependency file size/M type/bug Somehing is not working as expected labels Dec 2, 2024
@loki-gh-app loki-gh-app bot requested a review from paul1r December 2, 2024 21:01
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Kubernetes Manifest Diff Summary

Scenario: default-single-binary-values (Added: 0, Modified: 0, Removed: 0)

Summary:

  • Added: 0

  • Modified: 0

  • Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

Scenario: default-values (Added: 0, Modified: 0, Removed: 0)

Summary:

  • Added: 0

  • Modified: 0

  • Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

Scenario: ingress-values (Added: 0, Modified: 0, Removed: 0)

Summary:

  • Added: 0

  • Modified: 0

  • Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

Scenario: legacy-monitoring-values (Added: 0, Modified: 0, Removed: 0)

Summary:

  • Added: 0

  • Modified: 0

  • Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

Scenario: simple-scalable-aws-kube-irsa-values (Added: 0, Modified: 0, Removed: 0)

Summary:

  • Added: 0

  • Modified: 0

  • Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

@paul1r paul1r merged commit 17ac28a into release-3.3.x Dec 2, 2024
75 checks passed
@paul1r paul1r deleted the backport-15203-to-release-3.3.x branch December 2, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm backport dependencies Pull requests that update a dependency file size/M type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant