fix(helm): Add label to exlude memcache extstore volume from disk full alerting #15162
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bePersistentVolumeFillingUp The volume is meant to be full so the standard monitoring alert will be noise. The alert is described at https://github.com/prometheus-operator/kube-prometheus/wiki/kubepersistentvolumefillingup But I found a magic label that can be attached to the PVC: kubernetes-monitoring/kubernetes-mixin#711
This comment has been minimized.
This comment has been minimized.
chaudum
changed the title
This comment has been minimized.
This comment has been minimized.
Kubernetes Manifest Diff SummaryScenario: default-single-binary-values (Added: 0, Modified: 0, Removed: 0)
Summary:
Added FilesNo added files Modified FilesNo modified files Removed FilesNo removed files Scenario: default-values (Added: 0, Modified: 0, Removed: 0)
Summary:
Added FilesNo added files Modified FilesNo modified files Removed FilesNo removed files Scenario: ingress-values (Added: 0, Modified: 0, Removed: 0)
Summary:
Added FilesNo added files Modified FilesNo modified files Removed FilesNo removed files Scenario: legacy-monitoring-values (Added: 0, Modified: 0, Removed: 0)
Summary:
Added FilesNo added files Modified FilesNo modified files Removed FilesNo removed files Scenario: simple-scalable-aws-kube-irsa-values (Added: 0, Modified: 0, Removed: 0)
Summary:
Added FilesNo added files Modified FilesNo modified files Removed FilesNo removed files |
|
@chaudum I added the CHANGELOG entry. But I have a concern with this PR. Upgrades of this chart will fail when the memcached persistence is already enabled, because labels on a StatefulSet PVC are immutable: This may be annoying for users. WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Memcached: Add special label that exludes the always full extstore PVC from the alert KubePersistentVolumeFillingUp
The volume is meant to be full so the standard monitoring alert will be noise.
The alert is described at https://github.com/prometheus-operator/kube-prometheus/wiki/kubepersistentvolumefillingup
But I found a magic label that can be attached to the PVC:
kubernetes-monitoring/kubernetes-mixin#711
Related to #14049
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR